Skip to content
This repository was archived by the owner on Dec 21, 2023. It is now read-only.

fix: Support Openshift 3.11#6578

Merged
odubajDT merged 2 commits intomasterfrom
fix/4407/kubernetes-deprecation
Jan 18, 2022
Merged

fix: Support Openshift 3.11#6578
odubajDT merged 2 commits intomasterfrom
fix/4407/kubernetes-deprecation

Conversation

@odubajDT
Copy link
Copy Markdown
Contributor

@odubajDT odubajDT commented Jan 13, 2022 •
edited
Loading

github-actions[bot]
github-actions bot reviewed Jan 13, 2022
View reviewed changes
Comment thread cli/main.go Outdated
@odubajDT odubajDT added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Jan 13, 2022
@odubajDT odubajDT force-pushed the fix/4407/kubernetes-deprecation branch from adbc1ad to b08d3cd Compare January 13, 2022 11:32
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2022 •
edited
Loading

Codecov Report

Merging #6578 (8e024a3) into master (40e2deb) will decrease coverage by 2.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6578      +/-   ##
==========================================
- Coverage   59.91%   57.38%   -2.53%     
==========================================
  Files         475      486      +11     
  Lines       26453    27784    +1331     
  Branches     1283     1295      +12     
==========================================
+ Hits        15848    15945      +97     
- Misses       9429    10657    +1228     
- Partials     1176     1182       +6
Impacted Files Coverage Δ
resource-service/common/files.go 38.60% <0.00%> (-11.81%) ⬇️
...project-settings/ktb-project-settings.component.ts 76.58% <0.00%> (-3.42%) ⬇️
...idge/client/app/app-header/app-header.component.ts 47.89% <0.00%> (-2.54%) ⬇️
shipyard-controller/handler/sequencedispatcher.go 70.54% <0.00%> (-1.56%) ⬇️
resource-service/common/git.go 61.79% <0.00%> (-0.57%) ⬇️
resource-service/handler/project_manager.go 96.87% <0.00%> (-0.40%) ⬇️
bridge/client/app/app.module.ts 100.00% <0.00%> (ø)
bridge/client/app/app.routing.ts 100.00% <0.00%> (ø)
resource-service/handler/common.go 100.00% <0.00%> (ø)
resource-service/common/credentials.go 100.00% <0.00%> (ø)
... and 13 more
Flag Coverage Δ
bridge2 74.56% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as draft January 13, 2022 13:37
@odubajDT odubajDT force-pushed the fix/4407/kubernetes-deprecation branch from b08d3cd to b90ccd1 Compare January 14, 2022 09:52
@odubajDT odubajDT changed the title fix: Deprecate Kubernetes versions under v1.19 fix: Deprecate Kubernetes versions under v1.19 + support Openshift 3.11 Jan 14, 2022
@odubajDT odubajDT force-pushed the fix/4407/kubernetes-deprecation branch 2 times, most recently from cf47147 to 988db52 Compare January 14, 2022 10:17
@odubajDT odubajDT marked this pull request as ready for review January 14, 2022 10:30
@odubajDT odubajDT force-pushed the fix/4407/kubernetes-deprecation branch from 988db52 to 00b2a55 Compare January 14, 2022 12:33
@odubajDT odubajDT changed the title fix: Deprecate Kubernetes versions under v1.19 + support Openshift 3.11 fix: Support Openshift 3.11 Jan 14, 2022
mowies
mowies suggested changes Jan 17, 2022
View reviewed changes
Comment thread installer/manifests/keptn/charts/control-plane/templates/ingress.yaml Outdated
@odubajDT odubajDT requested a review from mowies January 17, 2022 08:44
@odubajDT
fix: Support Openshift 3.11
aa5d2ee 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT force-pushed the fix/4407/kubernetes-deprecation branch from 00b2a55 to aa5d2ee Compare January 17, 2022 09:20
mowies
mowies suggested changes Jan 18, 2022
View reviewed changes
Comment thread installer/manifests/keptn/charts/control-plane/templates/ingress.yaml Outdated
Comment thread installer/manifests/keptn/charts/control-plane/templates/ingress.yaml Outdated
@odubajDT
fixed review
8e024a3 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
Copy link
Copy Markdown
Contributor Author

odubajDT commented Jan 18, 2022 •
edited
Loading

@mowies fixed, thank you :)

@odubajDT odubajDT requested a review from mowies January 18, 2022 11:00
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit c72dbf2 into master Jan 18, 2022
@mowies mowies deleted the fix/4407/kubernetes-deprecation branch May 4, 2022 06:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@christian-kreuzberger-dtx christian-kreuzberger-dtx Awaiting requested review from christian-kreuzberger-dtx

2 more reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mowies mowies mowies approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate Kubernetes Versions below 1.19

2 participants

@odubajDT @mowies