This repository was archived by the owner on Dec 21, 2023. It is now read-only.
updated ingress manifest in configure-istio.sh#178
Merged
Conversation
…ith v1 k8s networking api Signed-off-by: warber <bernd.warmuth@dynatrace.com>
bacherfl
approved these changes
Jun 17, 2021
mowies
approved these changes
Jun 17, 2021
Member
mowies
left a comment
There was a problem hiding this comment.
LGTM, just left a small comment
| service: | ||
| name: api-gateway-nginx | ||
| port: | ||
| number: 80 |
Member
There was a problem hiding this comment.
[nitpick] if possible, please use a port name instead of a number. the port name should be defined in the api-gateway-nginx service
Contributor
Author
There was a problem hiding this comment.
good hint, let's consider changing this in the next iteration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #177
Signed-off-by: warber bernd.warmuth@dynatrace.com