Skip to content
This repository was archived by the owner on Dec 21, 2023. It is now read-only.

#165 Added SLO file for dynatrace self healing example#169

Merged
christian-kreuzberger-dtx merged 3 commits intomasterfrom
feature/165/closed_loop_remediation
May 18, 2021
Merged

#165 Added SLO file for dynatrace self healing example#169
christian-kreuzberger-dtx merged 3 commits intomasterfrom
feature/165/closed_loop_remediation

Conversation

@christian-kreuzberger-dtx
Copy link
Copy Markdown
Member

@christian-kreuzberger-dtx christian-kreuzberger-dtx commented May 14, 2021 •
edited
Loading

Fixes #165

  • Added remediation sequence and task to shiypard.yaml
  • Added a separate SLO config for self healing with dynatrace and added problem_open as a key_sli
  • renamed existing SLO config for self healing to indicate that it just works with prometheus

While the changes as requested in #165 are done, I believe we should wait before merging this PR until we have look at keptn/keptn#4075

Tutorials have been updated as well: keptn/tutorials#164

@christian-kreuzberger-dtx
#165 Added SLO file for dynatrace self healing example
3f9db07 
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
@christian-kreuzberger-dtx
keptn/keptn#4079 Add timeframe to evaluation task in closed loop reme…
53710c7 
…diation

Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
@christian-kreuzberger-dtx christian-kreuzberger-dtx mentioned this pull request May 17, 2021
Closed
7 tasks
bacherfl
bacherfl reviewed May 18, 2021
View reviewed changes
Comment thread onboarding-carts/shipyard.yaml
@christian-kreuzberger-dtx
Update shipyard spec to 0.2.2
5e1e7fe 
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
bacherfl
bacherfl approved these changes May 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@christian-kreuzberger-dtx christian-kreuzberger-dtx merged commit dba77ad into master May 18, 2021
@christian-kreuzberger-dtx christian-kreuzberger-dtx deleted the feature/165/closed_loop_remediation branch May 18, 2021 07:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AloisReitbauer AloisReitbauer Awaiting requested review from AloisReitbauer AloisReitbauer is a code owner

@danielkhan danielkhan Awaiting requested review from danielkhan

1 more reviewer

@bacherfl bacherfl bacherfl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prepare an SLO/SLI file that checks whether the Problem has been closed (as part of the remediation process)

2 participants

@christian-kreuzberger-dtx @bacherfl