feature: Add musicbrainzid as parameter alias#15
Closed
RustyNova016 wants to merge 1 commit intokepstin:masterfrom
Closed
feature: Add musicbrainzid as parameter alias#15RustyNova016 wants to merge 1 commit intokepstin:masterfrom
musicbrainzid as parameter alias#15RustyNova016 wants to merge 1 commit intokepstin:masterfrom
Conversation
Owner
|
I've merged this code into the beta branch, and deployed it to https://magicisrc-beta.kepstin.ca/ - I've also updated the seeding documentation with information about the new parameter name and why someone might want to use it. I'm testing this now and would appreciate any other feedback - hopefully i can deploy it to the main site soon. |
Contributor
Author
|
Neat! I will be able to finally add isrc from harmony... Well I need to ready the PR over there too. |
Owner
|
Released in v20240922.0 with a fix to remove the duplicate parameter from the URL after the page loads. |
Contributor
Author
|
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the website looks for the parameter
mbidin the URL. However,mbidoften is associated with tracking and on browsers with any decent tracking protection (like Firefox and Librewolf, or extensions), this parameter get removed from the url.So I added a alias that doesn't get flagged as tracking, and kept the old one as well for backward compatibility