Merged
Conversation
kepstin
requested changes
Feb 3, 2024
Owner
kepstin
left a comment
There was a problem hiding this comment.
Functionality generally looks ok here, although there are some problems with the changes made to the html escaping function - and you've introduced a security issue with cross site html injection!
I have a few suggestions for improving the appearance of the form.
Contributor
Author
|
Sorry for not responding - the change requests weren't shown prominently in my GitHub inbox. I'll have a look on the weekend. |
4c2749e to
9a0c18c
Compare
Owner
|
Thanks for the updates. Hopefully it won't be long before I have time to take another look at this. |
This commits start work to enable adding edit notes https://tickets.metabrainz.org/browse/MBS-6048
add edit-note to submitted xml
Rename a few functions to match other other functions with similar functionality. Don't double-escape the edit note when submitting. Move the edit note field down below the edit preview and add a copy of the MusicBrainz edit note field description.
Owner
|
Support for edit note submission is now live on https://magicisrc-beta.kepstin.ca/ - please try it out! I plan to merge it to the main release branch soon unless I discover any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to add edit-notes to submissions both interactively and through query parameters
(Fixes #9)
can be tested at https://reubot.github.io/magicisrc