fix(tools): pass skill env vars to remote backends#1
Draft
kentimsit wants to merge 1 commit into
Draft
Conversation
2 tasks
907592d to
39f2ca6
Compare
Owner
Author
|
Restacked this branch on top of the latest PR 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Passes active skill/config passthrough environment variables into remote terminal backends.
This is the follow-up to the skill readiness fix. The first PR makes skill env var readiness env-driven and restores passthrough registration. This follow-up ensures those active passthrough vars are actually delivered to remote terminal execution paths.
This branch is intentionally stacked on top of:
fix/skill-env-remote-readinessRelationship to the first PR
This PR depends on the readiness fix branch and is intended for review as a stacked follow-up.
The new work here is:
Changes Made
tools/environments/base.pyto resolve active passthrough env vars from:tools.env_passthrough.get_all_passthrough()os.environload_env()as fallbackdocker exec -eexport KEY=...;statements before the commandHow to Test
uv run --extra dev python -m pytest tests/tools/test_skills_tool.py tests/tools/test_skill_env_passthrough.py tests/tools/ test_env_passthrough.py tests/tools/test_docker_environment.py tests/tools/test_daytona_environment.py tests/tools/test_ssh_environment.py -qTest Results
152 passed, 11 skippedPlatform Tested
Notes
This PR is stacked on top of the readiness-fix branch. After the first PR merges, I will rebase this branch onto
upstream/mainso thefinal upstream PR contains only the remote backend passthrough changes.