Skip to content

fix: fix search bar cursor not blinking when focused#20

Merged
kencx merged 1 commit intomasterfrom
blinkingCursor
Nov 24, 2022
Merged

fix: fix search bar cursor not blinking when focused#20
kencx merged 1 commit intomasterfrom
blinkingCursor

Conversation

@kencx
Copy link
Copy Markdown
Owner

@kencx kencx commented Nov 23, 2022

Closes #14.

textinput's cursor was not blinking as:

  • Blinking was not properly initialized
  • The Update function call of handleSearch was placed inside the KeyMsg switch-case statement, which meant the cursor would only blink on every key press.
  • m.Reset() was being infinitely called when the search bar was empty (oops)

@kencx kencx merged commit 729a92b into master Nov 24, 2022
@kencx kencx deleted the blinkingCursor branch November 24, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add blinking cursor when search is focused

1 participant