feat: Add user mention functionality to incident comments by hemangsk · Pull Request #4649 · keephq/keep

hemangsk · 2025-04-29T12:07:33Z

Added proper support for @mentions in incident comments. Created a dedicated CommentMention model with relationships to AlertAudit.

Closes #2187

📑 Description

✅ Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

ℹ Additional Information

/claim #2187

vercel · 2025-04-29T12:07:37Z

@hemangsk is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

CLAassistant · 2025-04-29T12:07:41Z

All committers have signed the CLA.

hemangsk · 2025-05-01T12:17:05Z

@talboren @shahargl , could you please take a look if this fulfils the requirements? Let me know if there are any changes required to the approach. I'm working on tests atm.

talboren · 2025-05-01T17:52:43Z

@greptile

talboren · 2025-05-01T17:52:54Z

@Kiryous may I ask your help with reviewing the UI part here? 🙏🏼

talboren · 2025-05-01T17:53:29Z

@talboren @shahargl , could you please take a look if this fulfils the requirements? Let me know if there are any changes required to the approach. I'm working on tests atm.

The functionality looks great! I'm just wondering if it's not a bit complex under the hood. Let me review a bit further.

greptile-apps

PR Summary

Added user mention functionality to incident comments, including a new CommentMention table and UI components for handling @mentions in the activity feed.

Added new CommentMention table with proper indexes and foreign key constraints in /keep/api/models/db/migrations/2025-04-29-15-21_1b12e6d6ad1f.py
Implemented mention dropdown UI with keyboard navigation in /keep-ui/app/(keep)/incidents/[id]/activity/ui/IncidentActivityComment.tsx
Added mention highlighting and user data fetching in /keep-ui/app/(keep)/incidents/[id]/activity/ui/IncidentActivityItem.tsx
Modified /keep/api/routes/incidents.py to handle tagged users in comments with proper transaction management
Added CommentMentionDto interface and updated AuditEvent type in /keep-ui/entities/alerts/model/types.ts

_{💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!}

_{9 file(s) reviewed, 9 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

keep-ui/app/(keep)/incidents/[id]/activity/ui/IncidentActivityItem.tsx

keep-ui/app/(keep)/incidents/[id]/activity/ui/IncidentActivityComment.tsx

keep/api/models/alert_audit.py

keep/api/models/incident.py

keep/api/models/db/alert.py

keep/api/models/db/migrations/versions/2025-04-29-15-21_1b12e6d6ad1f.py

tests/e2e_tests/incidents_alerts_tests/test_mentions_in_incident_comments.py

skynetigor · 2025-05-05T08:02:36Z

Hey!
Quick question — since we’re already using ReactQuill, could we integrate quill-mention to handle mentions instead of building a custom input from scratch?
It seems like a lighter approach, given that Quill is already part of our stack.

hemangsk · 2025-05-06T15:15:54Z

@skynetigor Thanks for the review! I'll get right on it

hemangsk · 2025-05-06T19:44:52Z

@skynetigor , I've updated the MR with quill-mention package and here's the comment box in action.

keep-ui/app/(keep)/incidents/[id]/activity/ui/IncidentCommentInput.tsx

Kiryous

Please check the comment on quill-mention.js lib

keep-ui/public/quill-mention.js

talboren · 2025-05-19T11:01:24Z

@Kiryous @skynetigor is this done?

vercel · 2025-05-19T11:10:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
keep	⬜️ Ignored (Inspect)	Visit Preview		May 21, 2025 2:03pm

hemangsk · 2025-05-20T03:54:47Z

@Kiryous I noticed that your PR #4841 has some refactoring of the CommentMention code in addition to the quill-mention fix. Shall we close this PR in favor of #4841 ?

Kiryous · 2025-05-20T07:06:06Z

@hemangsk hey! Please merge my PR into your branch and I have a few more important comments for you a bit later today.

hemangsk · 2025-05-20T09:17:04Z

@Kiryous Done 👍

Kiryous · 2025-05-20T15:04:50Z

@greptileai

greptile-apps

PR Summary

(updates since last review)

Added user mention functionality to incident comments with backend support and UI components.

Added extractTaggedUsers utility in /keep-ui/app/(keep)/incidents/[id]/activity/lib/extractTaggedUsers.ts to parse mentions from Quill editor content
Potential XSS vulnerability in /keep-ui/app/(keep)/incidents/[id]/activity/ui/IncidentActivityItem.tsx due to unsanitized HTML rendering
Added proper mention handling in /keep/api/routes/incidents.py with CommentMention model integration
Empty merge migration in /keep/api/models/db/migrations/versions/2025-05-19-18-48_90e3eababbf0.py needs review
Empty root package.json file needs to be addressed

_{17 file(s) reviewed, 14 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

keep-ui/app/(keep)/incidents/[id]/activity/lib/extractTaggedUsers.ts

keep-ui/app/(keep)/incidents/[id]/activity/ui/IncidentActivityItem.tsx

keep-ui/app/(keep)/incidents/[id]/activity/ui/IncidentActivityComment.tsx

keep-ui/app/(keep)/incidents/[id]/activity/ui/IncidentCommentInput.scss

keep/api/models/db/migrations/versions/2025-05-19-18-48_90e3eababbf0.py

keep/api/models/db/migrations/versions/2025-05-19-20-54_combined_commentmention.py

package.json

tests/e2e_tests/incidents_alerts_tests/test_mentions_in_incident_comments.py

Kiryous

hey @hemangsk! I left a few comments and greptileai bot also left a few important (I resolved unimportant). Please review and fix them and let's merge it!

reach out if you have questions

keep-ui/app/(keep)/incidents/[id]/activity/ui/IncidentActivityItem.tsx

keep/api/models/db/migrations/versions/2025-05-19-18-48_90e3eababbf0.py

keep-ui/app/(keep)/incidents/[id]/activity/lib/extractTaggedUsers.ts

keep-ui/app/(keep)/incidents/[id]/activity/ui/IncidentActivityItem.tsx

package.json

hemangsk · 2025-05-21T11:37:16Z

@Kiryous , I've pushed an update and all the changes are now done

Regarding #4649 (comment)

I added the usage of IncidentActivity 96b35b5

Please let me know if that's alright or should we tackle it differently?

codecov · 2025-05-21T14:06:00Z

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 30.87%. Comparing base (7d126de) to head (c2ca497).
Report is 26 commits behind head on main.

Files with missing lines	Patch %	Lines
keep/api/models/incident.py	55.55%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #4649       +/-   ##
===========================================
- Coverage   46.14%   30.87%   -15.28%     
===========================================
  Files         165       93       -72     
  Lines       17428    11051     -6377     
===========================================
- Hits         8043     3412     -4631     
+ Misses       9385     7639     -1746

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Kiryous

@hemangsk thank you for the changes, it looks good to me now! approving

github-actions · 2025-05-22T07:21:32Z

🚂 Fantastic work @hemangsk! Your very first PR to keep has been merged! 🎉🥳

You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌
If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! 🚀

For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩‍💻👨‍💻

dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 29, 2025

dosubot bot added the Feature A new feature label Apr 29, 2025

algora-pbc bot added the 🙋 Bounty claim label Apr 29, 2025

algora-pbc bot mentioned this pull request Apr 29, 2025

[🔨 Enhancement]: Allow tagging in Incident comment #2187

Closed

hemangsk force-pushed the hmg/tag branch 2 times, most recently from d2bdd19 to 8c758a1 Compare April 29, 2025 12:12

greptile-apps bot reviewed May 1, 2025

View reviewed changes

hemangsk force-pushed the hmg/tag branch from 5d00be2 to 5d968b0 Compare May 2, 2025 18:11

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 2, 2025

hemangsk force-pushed the hmg/tag branch from 5d968b0 to ca436f1 Compare May 2, 2025 18:12

hemangsk commented May 2, 2025

View reviewed changes

tests/e2e_tests/incidents_alerts_tests/test_mentions_in_incident_comments.py Show resolved Hide resolved

skynetigor requested review from Kiryous, skynetigor and talboren May 5, 2025 07:18

hemangsk force-pushed the hmg/tag branch 4 times, most recently from 1ea6e5a to c8507ad Compare May 6, 2025 19:42

hemangsk commented May 6, 2025

View reviewed changes

keep-ui/app/(keep)/incidents/[id]/activity/ui/IncidentCommentInput.tsx Outdated Show resolved Hide resolved

hemangsk force-pushed the hmg/tag branch from c8507ad to 3a9c268 Compare May 6, 2025 20:38

Kiryous requested changes May 15, 2025

View reviewed changes

keep-ui/public/quill-mention.js Outdated Show resolved Hide resolved

This was referenced May 19, 2025

feat: allow tagging in incident comments #4669

Closed

feat: implement user tagging in incident comments #4699

Closed

vercel bot deployed to Preview May 19, 2025 11:16 View deployment

Merge branch 'main' into hmg/tag

262bff5

vercel bot deployed to Preview May 19, 2025 11:37 View deployment

chore: merge migration heads

1da28cc

Kiryous mentioned this pull request May 19, 2025

feat: Add user mentions to incident comments #4841

Closed

Kiryous added 2 commits May 20, 2025 17:14

fix: update migration head

fb79e17

fix: proper quill-mention import and styles polish

ccf545e

vercel bot deployed to Preview May 20, 2025 10:29 View deployment

Kiryous self-requested a review May 20, 2025 14:54

greptile-apps bot reviewed May 20, 2025

View reviewed changes

Kiryous requested changes May 20, 2025

View reviewed changes

hemangsk added 2 commits May 21, 2025 19:29

refactor: Implement fixes suggested by greptile

2ebe419

refactor: Use IncidentActivity type in IncidentActivityItem()

96b35b5

hemangsk requested a review from Kiryous May 21, 2025 11:38

vercel bot deployed to Preview May 21, 2025 11:57 View deployment

refactor: Fix tests for incident comment

c2ca497

Kiryous approved these changes May 21, 2025

View reviewed changes

Kiryous merged commit 7c5b4c8 into keephq:main May 22, 2025
22 of 24 checks passed

Conversation

hemangsk commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

✅ Checks

ℹ Additional Information

Uh oh!

vercel bot commented Apr 29, 2025

Uh oh!

CLAassistant commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hemangsk commented May 1, 2025

Uh oh!

talboren commented May 1, 2025

Uh oh!

talboren commented May 1, 2025

Uh oh!

talboren commented May 1, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skynetigor commented May 5, 2025

Uh oh!

hemangsk commented May 6, 2025

Uh oh!

hemangsk commented May 6, 2025

Uh oh!

Uh oh!

Kiryous left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

talboren commented May 19, 2025

Uh oh!

vercel bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hemangsk commented May 20, 2025

Uh oh!

Kiryous commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hemangsk commented May 20, 2025

Uh oh!

Kiryous commented May 20, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kiryous left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hemangsk commented Apr 29, 2025 •

edited

Loading

CLAassistant commented Apr 29, 2025 •

edited

Loading

vercel bot commented May 19, 2025 •

edited

Loading

Kiryous commented May 20, 2025 •

edited

Loading

Kiryous left a comment •

edited

Loading

codecov bot commented May 21, 2025 •

edited

Loading