Skip to content

feat: Adds Icinga2 Provider#4604

Closed
DMMutua wants to merge 3 commits intokeephq:mainfrom
DMMutua:main
Closed

feat: Adds Icinga2 Provider#4604
DMMutua wants to merge 3 commits intokeephq:mainfrom
DMMutua:main

Conversation

@DMMutua
Copy link
Copy Markdown
Contributor

@DMMutua DMMutua commented Apr 22, 2025 •
edited
Loading

Closes #3810

📑 Description

Adds new Icinga2 Provider for Integration with Icinga2 Monitoring System. Implementation Entails:-

  • Basic auth with Icinga2 API
  • Alert fetch and mapping to Keep alert format
  • Icinga2 states mapping to Keep alert severities.
  • Alert acknowledgment and removal
  • Scope validations for r/w permissions

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

  • Follows [BaseProvider]
  • Uses requests session for connection pooling.
  • SSL verification config.
  • Alert Ids are of format {hostname}_{servicename}

/claim #3810

DMMutua added 2 commits April 16, 2025 14:46
@DMMutua
feat(providers): adds Icinga2 monitoring provider (keephq#3810)
d97e9c3 
- Implements Icinga2 provider with REST API integration
- Adds fetching service alerts support with severity mapping
- Implements alert acknowledgement and removal
- Adds provider scope validation for read/write access
@DMMutua
feat(providers): Icinga2 Provider configuration template (keephq#3810)
1305116 
    - Renames provider source files and directory
    - Adds config template for auth & deduplication rules
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 22, 2025

@DMMutua is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 22, 2025
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 22, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added Feature A new feature Provider Providers related issues labels Apr 22, 2025
@DMMutua DMMutua changed the title Adds Icinga2 Provider Feat: Adds Icinga2 Provider Apr 22, 2025
@DMMutua DMMutua changed the title Feat: Adds Icinga2 Provider feat: Adds Icinga2 Provider Apr 22, 2025
@algora-pbc algora-pbc bot mentioned this pull request Apr 22, 2025
Closed
@talboren
Copy link
Copy Markdown
Member

talboren commented Apr 23, 2025

@DMMutua it seems like the PR is missing the icon and documentation for Icinga, can you add it? Check out this for inspiration: #3930

Also - doesn't Icinga support webhooks for receiving alerts? Pushing is always better then pulling. Check out Icinga's event handlers: https://icinga.com/docs/icinga-2/latest/doc/03-monitoring-basics/#event-commands

talboren
talboren requested changes Apr 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment

@DMMutua
Copy link
Copy Markdown
Contributor Author

DMMutua commented Apr 23, 2025

@DMMutua it seems like the PR is missing the icon and documentation for Icinga, can you add it? Check out this for inspiration: #3930

Also - doesn't Icinga support webhooks for receiving alerts? Pushing is always better then pulling. Check out Icinga's event handlers: https://icinga.com/docs/icinga-2/latest/doc/03-monitoring-basics/#event-commands

@talboren okay. Working on it ...

@talboren talboren mentioned this pull request Apr 25, 2025
Closed
@talboren
Copy link
Copy Markdown
Member

talboren commented Apr 28, 2025

@DMMutua it seems like the PR is missing the icon and documentation for Icinga, can you add it? Check out this for inspiration: #3930
Also - doesn't Icinga support webhooks for receiving alerts? Pushing is always better then pulling. Check out Icinga's event handlers: https://icinga.com/docs/icinga-2/latest/doc/03-monitoring-basics/#event-commands

@talboren okay. Working on it ...

for now, I'm closing the PR. looking forward to re-opening it once you had a chance to fix those issues :)

@talboren talboren closed this Apr 28, 2025
@DMMutua
Copy link
Copy Markdown
Contributor Author

DMMutua commented May 6, 2025

hi @talboren.
I have had a chance to work on all issues you referenced above and I would like the PR re-opened to fix them

@talboren
Copy link
Copy Markdown
Member

talboren commented May 6, 2025

@DMMutua feel free to re-open the pr!

@DMMutua DMMutua mentioned this pull request May 7, 2025
Merged
9 tasks
@DMMutua
Copy link
Copy Markdown
Contributor Author

DMMutua commented May 7, 2025 •
edited
Loading

@tal I just opted to raise another new pr at #4728
I will be waiting for your review on the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talboren talboren talboren requested changes

Assignees

No one assigned

Labels

🙋 Bounty claim Feature A new feature Provider Providers related issues size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🔌 Provider]: Icinga

3 participants

@DMMutua @CLAassistant @talboren