Skip to content

feat: Workflow Secrets#3620

Merged
talboren merged 17 commits intokeephq:mainfrom
Mubashirshariq:Feat/Workflow-secrets
Mar 12, 2025
Merged

feat: Workflow Secrets#3620
talboren merged 17 commits intokeephq:mainfrom
Mubashirshariq:Feat/Workflow-secrets

Conversation

@Mubashirshariq
Copy link
Copy Markdown
Contributor

@Mubashirshariq Mubashirshariq commented Feb 21, 2025 •
edited
Loading

Closes #3554
/claim #3554

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 21, 2025

@Mubashirshariq is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 21, 2025
@Mubashirshariq Mubashirshariq marked this pull request as draft February 21, 2025 18:29
@talboren talboren changed the title Feat:Added secrets to workflows feat: Workflow Secrets Feb 23, 2025
talboren
talboren reviewed Feb 23, 2025
View reviewed changes
@Matvey-Kuk Matvey-Kuk requested a review from talboren February 24, 2025 08:29
@talboren
Copy link
Copy Markdown
Member

talboren commented Mar 3, 2025

@Mubashirshariq any news?

@Mubashirshariq
Copy link
Copy Markdown
Contributor Author

Mubashirshariq commented Mar 3, 2025

@Mubashirshariq any news?

Hi, I am a bit busy with my college work. I will complete it this weekend.

@talboren
Copy link
Copy Markdown
Member

talboren commented Mar 7, 2025

@Mubashirshariq please let me know if you are feeling like you won't have time to finalize this 🙏🏼

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2025 0:38am

@Mubashirshariq Mubashirshariq marked this pull request as ready for review March 9, 2025 11:56
@dosubot dosubot bot added the Feature A new feature label Mar 9, 2025
@algora-pbc algora-pbc bot mentioned this pull request Mar 9, 2025
Closed
@vikashsprem
Copy link
Copy Markdown
Contributor

vikashsprem commented Mar 9, 2025

Hey @talboren , Plz review.

talboren
talboren reviewed Mar 10, 2025
View reviewed changes
talboren
talboren reviewed Mar 10, 2025
View reviewed changes
talboren
talboren reviewed Mar 10, 2025
View reviewed changes
talboren
talboren reviewed Mar 10, 2025
View reviewed changes
talboren
talboren reviewed Mar 10, 2025
View reviewed changes
talboren
talboren reviewed Mar 10, 2025
View reviewed changes
@talboren
Copy link
Copy Markdown
Member

talboren commented Mar 10, 2025

@Mubashirshariq also, tests are failing - could you check that?
I would also like to add some documentation about secrets to the workflow docs (under docs) - can you do that?

@talboren
Copy link
Copy Markdown
Member

talboren commented Mar 10, 2025

Please:

  1. use our Button component (Button.tsx)
  2. fix the error displayed
  3. Think about value being also a dictionary, possibly (not only string) - no need to do something special but to make sure we save it as needed

CleanShot 2025-03-10 at 13 05 22

@shahargl shahargl self-requested a review March 12, 2025 10:01
shahargl
shahargl previously approved these changes Mar 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 12, 2025
@shahargl shahargl self-requested a review March 12, 2025 13:31
shahargl
shahargl approved these changes Mar 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@talboren talboren merged commit 202e9c7 into keephq:main Mar 12, 2025
10 of 14 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2025

🎉 Well done @Mubashirshariq! Two PRs merged already! 🎉🥳

With your second PR, you're on a roll, and your contributions are already making a difference. 🌟
Looking forward to seeing even more contributions from you. See you in Slack https://slack.keephq.dev 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talboren talboren talboren left review comments

@shahargl shahargl shahargl approved these changes

Assignees

No one assigned

Labels

🙋 Bounty claim Feature A new feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Workflow Secrets

4 participants

@Mubashirshariq @talboren @vikashsprem @shahargl