Skip to content

feat: added gitlab pipelines provider#353

Merged
shahargl merged 9 commits intokeephq:mainfrom
melsonic:melsonic
Sep 28, 2023
Merged

feat: added gitlab pipelines provider#353
shahargl merged 9 commits intokeephq:mainfrom
melsonic:melsonic

Conversation

@melsonic
Copy link
Copy Markdown
Contributor

Closes #326

Description

Added Gitlab Pipelines Provider to interact with the Gitlab Pipelines API.

/claim #326

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 23, 2023

@melsonic is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@melsonic melsonic changed the title added gitlab pipelines provider feat: added gitlab pipelines provider Sep 23, 2023
@talboren
Copy link
Copy Markdown
Member

Thanks! Will review it ASAP :)

Can you take a look at https://docs.keephq.dev/ and add the provider documentation? (How to get the webhook url, etc.)

Please also add a PNG of GitLab pipelines icon to keep-up/public/icons 🙏🏼

@melsonic
Copy link
Copy Markdown
Contributor Author

Thanks! Will review it ASAP :)

Can you take a look at https://docs.keephq.dev/ and add the provider documentation? (How to get the webhook url, etc.)

Please also add a PNG of GitLab pipelines icon to keep-up/public/icons 🙏🏼

Sure, I will update the documentation and the icon, and if the review recommends some change I will do that altogether.

Copy link
Copy Markdown
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just few small things -

  1. add the svg
  2. add docs (under docs/) how to use/get the token

@melsonic
Copy link
Copy Markdown
Contributor Author

lgtm just few small things -

  1. add the svg
  2. add docs (under docs/) how to use/get the token

Sure, I will add these changes ASAP 👍

@melsonic
Copy link
Copy Markdown
Contributor Author

lgtm just few small things -

  1. add the svg
  2. add docs (under docs/) how to use/get the token

Hi @shahargl before pushing a commit, please clarify these two points

  1. Is this the correct logo for Gitlab Pipelines?
    IMG_20230926_173331
  2. Is there any preferable format for the provider documentation?

@shahargl
Copy link
Copy Markdown
Member

yea you can use that logo, and per the docs, you can see other providers docs (and even template) under docs/providers

@melsonic
Copy link
Copy Markdown
Contributor Author

please review the changes @shahargl

Copy link
Copy Markdown
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the class name to GitlabpipelinesProvider so tests will pass

@melsonic
Copy link
Copy Markdown
Contributor Author

melsonic commented Sep 27, 2023

change the class name to GitlabpipelinesProvider so tests will pass

done! lmk if anything still needs to be changed

@shahargl shahargl self-requested a review September 28, 2023 11:24
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8828b45) 73.13% compared to head (9b6d638) 73.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   73.13%   73.13%           
=======================================
  Files          42       42           
  Lines        2092     2092           
=======================================
  Hits         1530     1530           
  Misses        562      562           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shahargl shahargl merged commit aa8dd56 into keephq:main Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Gitlab Pipelines Provider

3 participants