feat: Add styles to make Markdown work#3485
Conversation
|
@hp77-creator is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
|
@talboren Please let me know if this is alright? |
|
@hp77-creator Well done! However, as far as I see, there is some incompatibility with Summary form control in "Edit incident" modal. This is the screenshot: |
|
That shouldn't have happened, I think it is not rendering it, let me look into it. Will update you. Thanks |
|
@skynetigor |
|
@skynetigor can you share the type of formatting that you have used in your incident, I will try to recreate it. |
You need to have AI enabled and try to generate Incident summary with AI producing formatted text. It then is displayed good on Incident, but when you try to edit the incident, in the rich text Summary editor the formatting is broken.. |
|
Understood, but I don't have any API_KEY, so I guess I can't test it that way, can you share the text, which you see in the Edit window, I can try with that manner |
|
Sorry, I'm struggling to put this markdown text here because GH interprets it 🥲 |
|
If you can add it in a txt file and attach it, i guess that will work 🤔 |
Signed-off-by: hp <himanshu.dn.pandey@gmail.com>
|
@skynetigor yes you are right, so showing it in ReactQuill will need some more changes inside editor, just want to know was it working before? In the scope of original issue we wanted to get only format for summary, right? should I update |
|
Hi @hp77-creator Let's check this issue (if it's an issue) and merge it. Although not all cases covered, I think the main issue was solved here. Now "summary" on Incident is displayed well for both AI generated summary and for summary created using rich text editor in create/edit form. But the issue with incorrect handling of markdown in rich-text editor is worth being an another issue. |
|
Noted @skynetigor I agree that create/edit one could be another issue. I am willing to take up that. |
|
@skynetigor I have removed it. Let me know on the further course of action. |
|
@hp77-creator merging it, thank you for your contribution 🙏 |
|
🚂 Fantastic work @hp77-creator! Your very first PR to keep has been merged! 🎉🥳 You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌 For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩💻👨💻 |
|
@skynetigor thanks a lot for being so patient and helpful. I will pick up the other issue as well. Let me know when you create it. Also joining slack. |








Closes #3353
/claim #3353
📑 Description
Modified styles in markdown to use the styles with which the incidents are created:
✅ Checks
ℹ Additional Information
This is how it looks now
