Merged
Conversation
|
@ezhil56x is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
shahargl
reviewed
Sep 10, 2024
| - `Clickhouse Password`: The password to authenticate with ClickHouse. | ||
| - `Clickhouse Hostname`: The host where ClickHouse is running. | ||
| - `Clickhouse Port`: The port where ClickHouse is running. The default port is `9000`. | ||
| - `Clickhouse Database`: The database to connect to. (optional) |
Member
There was a problem hiding this comment.
why is this optional? what happens if this is not supplied?
shahargl
reviewed
Sep 10, 2024
Member
There was a problem hiding this comment.
its very low resolution (1kb, most of the icons are 10k+)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1889 +/- ##
==========================================
+ Coverage 30.68% 31.14% +0.46%
==========================================
Files 54 55 +1
Lines 5028 5114 +86
==========================================
+ Hits 1543 1593 +50
- Misses 3485 3521 +36 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1830
📑 Description
Added ClickHouse Provider
/claim #1830
✅ Checks
Additional Information
2024-09-10.17-24-27.mp4