Skip to content

feat: add the option to disable workflow#1766

Merged
Matvey-Kuk merged 11 commits intokeephq:mainfrom
nejcr:1739
Sep 11, 2024
Merged

feat: add the option to disable workflow#1766
Matvey-Kuk merged 11 commits intokeephq:mainfrom
nejcr:1739

Conversation

@nejcr
Copy link
Copy Markdown
Contributor

@nejcr nejcr commented Aug 31, 2024

Closes #1739

📑 Description

Added is_disabled to the workflow table and introduced disabled in the YAML configuration. Updated documentation and UI; see screenshots

✅ Checks

  • [ x ] My pull request adheres to the code style of this project
  • [ x ] My code requires changes to the documentation
  • [ x ] I have updated the documentation as required
  • [ x ] All the tests have passed

ℹ Additional Information

image
image

Also spent an hour or two figuring out how to run keep in PyCharm; I might open a separate PR to document the process."

/claim #1739

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 31, 2024

@nejcr is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 31, 2024

CLA assistant check
All committers have signed the CLA.

@talboren
Copy link
Copy Markdown
Member

talboren commented Sep 1, 2024

Not sure if I'm right but it might conflict with: #1488 which is about to get merged.

@nejcr
Copy link
Copy Markdown
Contributor Author

nejcr commented Sep 1, 2024

Not sure if I'm right but it might conflict with: #1488 which is about to get merged.

I can wait, looking at it, it would be easier for me if I resolved conflicts afterwards

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Sep 1, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@rajesh-jonnalagadda
Copy link
Copy Markdown
Contributor

@nejcr I think your changes are conflicting with my changes. please resolve them. post-resolution can you also share the final changes with me? If needed any clarification on new changes please do reach out to me.

@nejcr
Copy link
Copy Markdown
Contributor Author

nejcr commented Sep 1, 2024

@talboren I have resolved the conflicts with the main branch.

@rajeshj11 I incorporated some of your validator changes as they were necessary for proper functionality. The code should now be free of conflicts. Additionally, I simplified the nested ternary logic for better readability.

@nejcr nejcr force-pushed the 1739 branch 4 times, most recently from 63b0b29 to 5be3445 Compare September 2, 2024 08:35
@Matvey-Kuk
Copy link
Copy Markdown
Contributor

Matvey-Kuk commented Sep 2, 2024

Great PR from my point of view, thank you for the contribution! Waiting for tests :) Btw, alembic -c keep/alembic.ini history may help you to fight double-headed migrations (may be the reason E2E test are blocked).

@nejcr
Copy link
Copy Markdown
Contributor Author

nejcr commented Sep 2, 2024

Thank you, @Matvey-Kuk.

I have rebased the changes from the main branch to keep this PR up to date.

Please let me know if anything else is needed. (Note: There were some database setup issues with the tests running on GitHub Actions.)

@Matvey-Kuk
Copy link
Copy Markdown
Contributor

@nejcr I see the tests are still failing, please let me know if you are planning to fix them

@nejcr
Copy link
Copy Markdown
Contributor Author

nejcr commented Sep 6, 2024

@Matvey-Kuk I believe I’ve fixed it now. The tests passed locally, but I missed the final test run result. My mistake! It seems the unused import wasn’t detected locally. Let me know if there are any more issues.

@Matvey-Kuk Matvey-Kuk enabled auto-merge (squash) September 6, 2024 11:51
@Matvey-Kuk
Copy link
Copy Markdown
Contributor

Great work, thank you!

auto-merge was automatically disabled September 7, 2024 17:30

Head branch was pushed to by a user without write access

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 7:15am

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Sep 8, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@nejcr
Copy link
Copy Markdown
Contributor Author

nejcr commented Sep 10, 2024

@Matvey-Kuk @talboren another migration got into main before aproved workflows were triggered.
I've had to resolve another double headed migration.

@Matvey-Kuk Matvey-Kuk enabled auto-merge (squash) September 10, 2024 16:20
auto-merge was automatically disabled September 10, 2024 17:01

Head branch was pushed to by a user without write access

@nejcr
Copy link
Copy Markdown
Contributor Author

nejcr commented Sep 10, 2024

@Matvey-Kuk looks like something changed so now the pr tests are red.
I have added a possible fix(passes on 1739 branch).

@Matvey-Kuk Matvey-Kuk enabled auto-merge (squash) September 11, 2024 07:14
@Matvey-Kuk Matvey-Kuk merged commit b23778b into keephq:main Sep 11, 2024
@Matvey-Kuk
Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🔨 Enhancement]: add the option to disable a workflow

5 participants