feat: add the option to disable workflow#1766
Conversation
|
@nejcr is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
|
Not sure if I'm right but it might conflict with: #1488 which is about to get merged. |
I can wait, looking at it, it would be easier for me if I resolved conflicts afterwards |
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
|
@nejcr I think your changes are conflicting with my changes. please resolve them. post-resolution can you also share the final changes with me? If needed any clarification on new changes please do reach out to me. |
|
@talboren I have resolved the conflicts with the main branch. @rajeshj11 I incorporated some of your validator changes as they were necessary for proper functionality. The code should now be free of conflicts. Additionally, I simplified the nested ternary logic for better readability. |
63b0b29 to
5be3445
Compare
|
Great PR from my point of view, thank you for the contribution! Waiting for tests :) Btw, |
|
Thank you, @Matvey-Kuk. I have rebased the changes from the main branch to keep this PR up to date. Please let me know if anything else is needed. (Note: There were some database setup issues with the tests running on GitHub Actions.) |
|
@nejcr I see the tests are still failing, please let me know if you are planning to fix them |
|
@Matvey-Kuk I believe I’ve fixed it now. The tests passed locally, but I missed the final test run result. My mistake! It seems the unused import wasn’t detected locally. Let me know if there are any more issues. |
|
Great work, thank you! |
Head branch was pushed to by a user without write access
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
@Matvey-Kuk @talboren another migration got into main before aproved workflows were triggered. |
Head branch was pushed to by a user without write access
|
@Matvey-Kuk looks like something changed so now the pr tests are red. |
|
Thank you! |
Closes #1739
📑 Description
Added
is_disabledto theworkflowtable and introduceddisabledin the YAML configuration. Updated documentation and UI; see screenshots✅ Checks
ℹ Additional Information
Also spent an hour or two figuring out how to run
keepin PyCharm; I might open a separate PR to document the process."/claim #1739