fix: core/db - remove unused function. closes #1561#1560
Merged
Matvey-Kuk merged 1 commit intokeephq:mainfrom Aug 7, 2024
Merged
fix: core/db - remove unused function. closes #1561#1560Matvey-Kuk merged 1 commit intokeephq:mainfrom
Matvey-Kuk merged 1 commit intokeephq:mainfrom
Conversation
Now we have 2 definitions of the same function: ``` def get_incident_by_id(incident_id: UUID) -> Incident: def get_incident_by_id(tenant_id: str, incident_id: str) -> Optional[Incident]: ``` Only 2nd definition is used. I suppose there are no much reasons to keep first one.
|
@achivkun is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Matvey-Kuk
approved these changes
Aug 7, 2024
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1561
📑 Description
Now we have 2 definitions of the same function:
Only 2nd definition is used. I suppose there are no much reasons to keep first one.
✅ Checks