fix: problems with getting started instructions#1547
Merged
talboren merged 3 commits intokeephq:mainfrom Aug 5, 2024
Merged
Conversation
added 2 commits
August 5, 2024 17:47
Attempts to follow the instruction and run old-fashioned command (with dash) may result in error, for example this one: ``` $ docker-compose -f docker-compose.dev.yml up ERROR: The Compose file is invalid because: Service keep-frontend-dev has neither an image nor a build context specified. At least one must be provided. ``` or this: ``` File "compose/service.py", line 1579, in get_container_data_volumes KeyError: 'ContainerConfig' ``` We should use command without dash. See for example: https://askubuntu.com/a/1508135
In some cases (I didn't have time to check what is the trigger) we migh have situations, when 'next' binary is already present in /usr/local/bin/next. See: keephq#1524 keephq#1546 In this case we will get an error from docker: ``` => ERROR [8/8] RUN ln -s /usr/local/lib/node_modules/next/dist/bin/next /usr/local/bin/next 0.7s ------ > [8/8] RUN ln -s /usr/local/lib/node_modules/next/dist/bin/next /usr/local/bin/next: 0.408 ln: /usr/local/bin/next: File exists ``` We should not fail in this situation. This fix proposed by @soylent-grin in https://github.com/keephq/keep/pull/1523/files#diff-edc66b35c9059e6f4fd75aa0f568ec86249f535bd0715516621005e8fd9e1949R22 I'm using it here just to close the issuer faster, because those PR, where it is now might be long-lasting. *Probably it worth to understand why/when we are getting file already present, but right now I have no time for this. So I would consider this commit as workaround rather than a fix.
|
Someone is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
talboren
approved these changes
Aug 5, 2024
Member
talboren
left a comment
There was a problem hiding this comment.
LGTM! thank you for the contribution! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1524
📑 Description
We have few problems, which new developers may get while following getting started instruction.
✅ Checks