fix: labels in query params as a initial filters#1518
Merged
talboren merged 5 commits intokeephq:mainfrom Aug 5, 2024
Merged
Conversation
|
@andreizanik is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
|
|
# Conflicts: # keep-ui/app/providers/layout.tsx # keep-ui/app/providers/providers.tsx
Contributor
Author
|
fixed conflicts and updated types (added "topology") |
Member
|
@andreizanik thank you for the contribution! 🥳 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1512
📑 Description
Ignore unknown labels from query parameters and do not search for them
Add "queue" to filters
A bit of refactoring.
In my opinion, it is better to move some of the logic into small and independent components.
I also implemented a context provider that isolates the logic of determining the initial state of filters and provides the necessary methods and variables.
Stricter typing added in some places
✅ Checks