Skip to content

Passkeys: Rename User ID to Credential ID#9998

Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom
varjolintu:fix/passkeys_rename_user_id
Nov 9, 2023
Merged

Passkeys: Rename User ID to Credential ID#9998
droidmonkey merged 1 commit intokeepassxreboot:developfrom
varjolintu:fix/passkeys_rename_user_id

Conversation

@varjolintu
Copy link
Copy Markdown
Member

According to specifications, the value stored here is Credential ID, not User ID. User ID is stored as User Handle for later use, but the newly generated value is a Credential ID. These shouldn't be mixed, especially in the JSON file.

KPEX_PASSKEY_GENERATED_USER_ID is changed to KPEX_PASSKEY_CREDENTIAL_ID.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@varjolintu
Copy link
Copy Markdown
Member Author

Ping @strongbox-mark

@varjolintu varjolintu changed the title Rename userId to credentialId Passkeys: Rename User ID to Credential ID Nov 8, 2023
@strongbox-mark
Copy link
Copy Markdown

strongbox-mark commented Nov 8, 2023

Hi @varjolintu, thanks for the heads up!

We'll need to do some migration for this change as we have a lot of users now using the older name. I'll try get that into our next release.

I think, if it is at all possible, we should now freeze these things and consider them "API", this is the contract we can use to remain interoperable. I understand it is nice to have nice naming for these fields, but at the end of the day, it seems borderline cosmetic. I think we probably don't even want to show these field names to an end user (currently we show "Credential ID" to our users) in the normal view anyway.

If there are some users who are unhappy about this, I think the time to speak up was before this feature went live, during our development/design phase, and before thousands of users had already created their passkeys.

Fingers crossed we're good now, and thanks again for letting me know. :)

@droidmonkey
Copy link
Copy Markdown
Member

I absolutely agree with Mark, which is why I didn't quickly hit the merge button here. What is the cost of this switch in naming convention? It is entirely internal to the programs so we could "read" both fields and prefer the new one of it exists and matches the data pattern we expect.

Overall, I recommend no change here except to export the correct field to json. Keep the internal field name the same.

@varjolintu
Copy link
Copy Markdown
Member Author

Thanks for the feedback. I agree, let's only change the JSON content.

@varjolintu varjolintu force-pushed the fix/passkeys_rename_user_id branch from bac74f4 to 9fb3ba0 Compare November 8, 2023 13:28
@strongbox-mark
Copy link
Copy Markdown

That's great, thanks guys! Saves me a bunch of work :) Cheers

@droidmonkey droidmonkey merged commit a3717c7 into keepassxreboot:develop Nov 9, 2023
@varjolintu varjolintu deleted the fix/passkeys_rename_user_id branch November 10, 2023 04:36
@jasperweiss
Copy link
Copy Markdown

In fairness, this isn't in the release yet. I don't think anything should be considered final spec until it is. People will inevitably find things to change still during testing.

@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Jan 12, 2024
@phoerious phoerious added pr: bugfix Pull request fixes a bug and removed bug labels Nov 22, 2024
@phoerious phoerious modified the milestones: v2.8.0, v2.7.7 Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: Browser pr: backported Pull request backported to previous release pr: bugfix Pull request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants