Skip to content

Fix clicking links in entry preview panel#8644

Merged
droidmonkey merged 1 commit intodevelopfrom
fix/preview-url-click
Oct 27, 2022
Merged

Fix clicking links in entry preview panel#8644
droidmonkey merged 1 commit intodevelopfrom
fix/preview-url-click

Conversation

@droidmonkey
Copy link
Copy Markdown
Member

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added this to the v2.7.4 milestone Oct 25, 2022
@droidmonkey droidmonkey requested a review from phoerious October 25, 2022 03:48
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 27, 2022

Codecov Report

Base: 64.26% // Head: 64.28% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (f23f30e) compared to base (d83743e).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8644      +/-   ##
===========================================
+ Coverage    64.26%   64.28%   +0.03%     
===========================================
  Files          341      341              
  Lines        44329    44333       +4     
===========================================
+ Hits         28484    28499      +15     
+ Misses       15845    15834      -11     
Impacted Files Coverage Δ
src/gui/DatabaseWidget.cpp 61.30% <ø> (-0.03%) ⬇️
src/gui/EntryPreviewWidget.cpp 84.04% <75.00%> (-0.56%) ⬇️
src/core/Entry.cpp 82.52% <0.00%> (-0.20%) ⬇️
src/core/FileWatcher.cpp 86.75% <0.00%> (+1.20%) ⬆️
src/fdosecrets/dbus/DBusMgr.cpp 53.67% <0.00%> (+1.47%) ⬆️
...rc/fdosecrets/widgets/SettingsWidgetFdoSecrets.cpp 59.09% <0.00%> (+3.03%) ⬆️
src/gui/Clipboard.cpp 85.96% <0.00%> (+7.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@droidmonkey droidmonkey merged commit 03f11ce into develop Oct 27, 2022
@droidmonkey droidmonkey deleted the fix/preview-url-click branch October 27, 2022 21:18
@droidmonkey droidmonkey mentioned this pull request Oct 29, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed backport-pending labels Oct 29, 2022
@phoerious phoerious added pr: bugfix Pull request fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: backported Pull request backported to previous release pr: bugfix Pull request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clicking on URL link no longer opens link - 2.7.3

3 participants