Prevent expired entries search if no results returned#8643
Prevent expired entries search if no results returned#8643droidmonkey merged 1 commit intodevelopfrom
Conversation
|
If the user initiates a search manually (doesn't matter where from), I think they'd expect to see something, even if the results are empty. I'm not entirely clear if this PR takes that into account or not. But anyway, the real fix for #8626 would be to finish #7791 . @droidmonkey , how about including that in 2.7.4? |
|
The code introduced here only ends the search if no entries are found when the "next search label" variable is set. This variable is only set when performing the expired entries on unlock search. Although it looks like the gui tests are failing on search. |
83b8b0a to
1503b2f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8643 +/- ##
===========================================
+ Coverage 64.41% 64.42% +0.01%
===========================================
Files 341 341
Lines 44242 44245 +3
===========================================
+ Hits 28496 28504 +8
+ Misses 15746 15741 -5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
1503b2f to
c288e37
Compare
* Fixes #8626 * Also remove old feature to set the title of a new entry to the current search text. This only made sense before advanced searching was made available.
c288e37 to
26973fe
Compare
Type of change