Skip to content

Pass database locked/unlocked status even with Search In All Opened Databases option enabled#8114

Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom
varjolintu:fix/pass_database_status_in_every_case
Jun 6, 2022
Merged

Pass database locked/unlocked status even with Search In All Opened Databases option enabled#8114
droidmonkey merged 1 commit intokeepassxreboot:developfrom
varjolintu:fix/pass_database_status_in_every_case

Conversation

@varjolintu
Copy link
Copy Markdown
Member

@varjolintu varjolintu commented Jun 5, 2022

Reverts a bad fix made in #4660. Originally it was made to fix showing Access Confirm Dialog at database change, but it seems to work OK with the latest extension. This "fix" failed to pass database status to the extension, causing missing icon state updates.

Testing strategy

Manually:

  • Enable "Search in all databases" in KeePassXC
  • Without this fix, icons are not updated in the extension when switching between databases, no matter if it's locked, not connected etc.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@varjolintu varjolintu added this to the v2.7.2 milestone Jun 5, 2022
@varjolintu varjolintu requested a review from droidmonkey June 5, 2022 14:15
@varjolintu varjolintu changed the title Pass database locked/unlocked status even with Search All Databases option enabled Pass database locked/unlocked status even with Search In All Opened Databases option enabled Jun 5, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 5, 2022 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.44%. Comparing base (b5e0572) to head (b44a406).
Report is 419 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8114      +/-   ##
===========================================
- Coverage    64.45%   64.44%   -0.00%     
===========================================
  Files          339      339              
  Lines        43613    43612       -1     
===========================================
- Hits         28107    28105       -2     
- Misses       15506    15507       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@droidmonkey droidmonkey merged commit 924eb6d into keepassxreboot:develop Jun 6, 2022
@varjolintu varjolintu deleted the fix/pass_database_status_in_every_case branch June 6, 2022 04:45
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed backport-pending labels Jun 27, 2022
@varjolintu varjolintu mentioned this pull request Mar 16, 2023
Open
@phoerious phoerious added pr: bugfix Pull request fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

Assignees

No one assigned

Labels

feature: Browser pr: backported Pull request backported to previous release pr: bugfix Pull request fixes a bug

Projects

None yet

Milestone

v2.7.2

Development

Successfully merging this pull request may close these issues.

4 participants

@varjolintu @codecov-commenter @droidmonkey @phoerious