FdoSecrets: ask to unlock the database before storing entries#8022
Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom Jun 4, 2022
Merged
Conversation
5d76ee5 to
94bdf7d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #8022 +/- ##
===========================================
+ Coverage 64.35% 64.36% +0.02%
===========================================
Files 339 339
Lines 43535 43576 +41
===========================================
+ Hits 28014 28047 +33
- Misses 15521 15529 +8
Continue to review full report at Codecov.
|
droidmonkey
approved these changes
Jun 4, 2022
Also only emit databaseUnlockFinished after the database is unlocked Fix keepassxreboot#7989
94bdf7d to
5d0879e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7989.
As creating items in the spec can return a proper prompt object, we can implement this without the blocking hack used in "unlock before searching". So this is enabled unconditionally.
Testing strategy
Added unit test
Type of change