Skip to content

FdoSecrets: skip entries in recycle bin when searching#8021

Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom
Aetf:fix/fdosecrets-recyclebin
May 28, 2022
Merged

FdoSecrets: skip entries in recycle bin when searching#8021
droidmonkey merged 1 commit intokeepassxreboot:developfrom
Aetf:fix/fdosecrets-recyclebin

Conversation

@Aetf
Copy link
Copy Markdown
Contributor

@Aetf Aetf commented May 6, 2022

When the recycle bin is under the exposed group, searching will return entries in the recycle bin.

fix #7933, replaces #7850

Testing strategy

Added unit test

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@Aetf Aetf force-pushed the fix/fdosecrets-recyclebin branch from 8d0f95a to 9a2f6ae Compare May 6, 2022 22:04
@Aetf Aetf changed the title FdoSecrets: skip entries in recycle bin when searching (fix #7933) FdoSecrets: skip entries in recycle bin when searching May 6, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 6, 2022

Codecov Report

Merging #8021 (9a2f6ae) into develop (a4d4adb) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #8021      +/-   ##
===========================================
- Coverage    64.29%   64.29%   -0.00%     
===========================================
  Files          339      339              
  Lines        43431    43433       +2     
===========================================
+ Hits         27923    27924       +1     
- Misses       15508    15509       +1     
Impacted Files Coverage Δ
src/fdosecrets/objects/Collection.h 0.00% <ø> (ø)
src/fdosecrets/objects/Collection.cpp 84.84% <100.00%> (+0.03%) ⬆️
src/fdosecrets/objects/Service.cpp 82.80% <100.00%> (+0.05%) ⬆️
src/core/FileWatcher.cpp 85.54% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d4adb...9a2f6ae. Read the comment docs.

@bionade24
Copy link
Copy Markdown

When will a release or a backport of this fix come out?

@droidmonkey
Copy link
Copy Markdown
Member

@Aetf In general I don't like leaving naked Q_ASSERT(pointer) checks because they will lead to an undiagnosed crash if they are hit in release build. We really should consider graceful exists and error messages (when necessary) for release builds.

@droidmonkey droidmonkey merged commit a4c5997 into keepassxreboot:develop May 28, 2022
@Aetf
Copy link
Copy Markdown
Contributor Author

Aetf commented May 29, 2022

@Aetf In general I don't like leaving naked Q_ASSERT(pointer) checks because they will lead to an undiagnosed crash if they are hit in release build. We really should consider graceful exists and error messages (when necessary) for release builds.

Will keep that in mind!

@bionade24
Copy link
Copy Markdown

When will there be a new release with this fix or a backport of this bugfix?

@droidmonkey
Copy link
Copy Markdown
Member

You can use it right now at https://snapshot.keepassxc.org

@michaelk83
Copy link
Copy Markdown

You can also just clear the recycle bin, or define a separate group for FdoSecrets that doesn't include the recycle bin.

@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed backport-pending labels Jun 27, 2022
@Aetf Aetf deleted the fix/fdosecrets-recyclebin branch December 5, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: Secret Service pr: backported Pull request backported to previous release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when using the secret service on a secret with a matching entry in the recycle bin

5 participants