Make notes hidden by default#541
Conversation
|
I'm deferring this to 2.3.0 since it is niche and there may be betters ways to address the visibility issue. |
|
I see the "needs work" tag was added. Is there anything I need to fix that would prevent the code from being merged as-is? |
|
Only what @droidmonkey wrote. |
|
The issue with the current implementation is that the feature is on by default and is hard to "discover". When the notes are hidden, the text area should be replaced with a simple note that states "Notes are hidden, show them by clicking the checkbox to the left". I do not agree that the checkbox should be unchecked by default, but rather a configuration option added (default to SHOW NOTES). |
|
@grim210 I think all that's left here would be to add the default to the config. @droidmonkey is that right? |
|
I agree looks good, just need a config option. |
|
@grim210 is this still under development or can I continue it myself? |
|
Its all you |
|
Closed in favor of #1124 since I can't add commit to this PR :) |
Description
I prefer the notes section to be fixed width (#540). When searching for an issue on the issue tracker, I found #342, which seems like it would be easy to fix while I was working on my own issue. Overall, it was a simple fix for both.
Motivation and context
Commit 636b3a0 fixes the issue that I created: #540.
Commit b9531a7 fixes issue #342.
How has this been tested?
Tried on existing database (my personal one, a few years old), and on a fresh database that was created for the screenshots below. Notes persisted through save. Disabling the notes after writing them does not erase them.
Tested on Ubuntu MATE 16.04.2 amd64, with Qt 5.5.1. All tests in the 'tests' directory were passed (except the YubiKey ones; I don't have one). There were no apparent side effects during testing.
Screenshots (if appropriate):
This is what the entry looks like by default:
When the notes section has been enabled, it looks like this:
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]