add warning for large collective attachment size#4683
Closed
paudelprabesh wants to merge 1 commit intokeepassxreboot:developfrom
Closed
add warning for large collective attachment size#4683paudelprabesh wants to merge 1 commit intokeepassxreboot:developfrom
paudelprabesh wants to merge 1 commit intokeepassxreboot:developfrom
Conversation
Member
|
Please combine with the other pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EditEntryWidget is changed such that if total attachment size for the current entry is > 50, a warning is issued which warns the user if they want to continue with such large total attachment size.
The warning will also show the total size of all the attachments from database and only continues if the user presses yes.
Complements pull request #4651 to address Issue -#3782
Screenshots
User selects a file such that collective size for current entry becomes >50.
User given warning and only continues if user selects Yes.
Testing strategy
Manually.
Type of change