Enable browser-like DbTab (Alt + Num) experience across platforms with fixes#4306
Enable browser-like DbTab (Alt + Num) experience across platforms with fixes#4306JulianVolodia wants to merge 5 commits intokeepassxreboot:developfrom
Conversation
f6f6e68 to
c66ad41
Compare
This is follow up of: PR keepassxreboot#4063 Enable browser-like DbTab experience (Alt + Nums) PR keepassxreboot#4305 Fix browser-like DbTab experience with macOS This commit introduces desired behaviour across platforms. On MacOS only Command key + Nums combination should be used. (on MacOS, ⌘Command is QT::CTRL) On Linux and Windows there are combinations with Ctrl and (Left) Alt. (code could be reused) This is not breaking for various keyboard layout organization on MacOS because of @varjolintu fixes, nor breaking on Linux or Windows because they use AltGr (Right Alt) as modkey.
Selecting last not use shortcut variable and is edge case here. This minimalize PR commit diff also.
| new QShortcut(Qt::ALT + Qt::Key_0, this, SLOT(selectLastDatabaseTab())); | ||
|
|
||
| auto shortcut = new QShortcut(Qt::ALT + Qt::Key_1, this); | ||
| new QShortcut(Qt::CTRL + Qt::Key_9, this, SLOT(selectLastDatabaseTab())); |
There was a problem hiding this comment.
Now you are keeping CTRL+9 shortcut alive even with WIndows systems. Why did you remove the previous ifdef?
|
@droidmonkey could you rethink that last time? If Chrome (on LInux) have it enabled and is most used browser maybe they know how to do it right way? Ppl using KeePassXC on different platforms could be suprised that on Windows work something but on Linux not. Chrome is cross-platform and Edge is not equal to Chrome. Also, there is no problem with collisions on Linux and Windows now for Keepass, and Win Key (modkey 4 if I correctly recall) is used by default on AwesomeWM or some freaky WM out there, to manipulate desktops/views. |
|
At this point I have already spent enough time on this feature and will not be addressing any further PR's for it. There are much more important things to work on for 2.6.0. |
Improvement of PR #4063 and apply of PR #4305 hotfix made by @varjolintu
Type of change
Description and Context
Enable browser-like DbTab (Alt + Num) experience across platforms
This is follow up of:
PR #4063 Enable browser-like DbTab experience (Alt + Nums)
PR #4305 Fix browser-like DbTab experience with macOS
This commit introduces desired behaviour across platforms.
On MacOS only Command key + Nums combination should be used. (on MacOS, ⌘Command is QT::CTRL)
On Linux and Windows there are combinations with Ctrl and (Left) Alt. (code could be reused)
This is not breaking for various keyboard layout organization on MacOS because of @varjolintu fixes,
nor breaking on Linux or Windows because they use AltGr (Right Alt) as modkey.
edge case over common case
Selecting last not use shortcut variable and is edge case here. This minimalize PR commit diff also.
Change Key_0 to Key_9
Fix browser-like DbTab experience with macOS
white space removal
Testing strategy
not tested
Checklist: