Fix bugs introduced by database refactor #2491#2503
Merged
droidmonkey merged 3 commits intodevelopfrom Nov 23, 2018
Merged
Conversation
07862f2 to
62dc4f4
Compare
droidmonkey
approved these changes
Nov 23, 2018
Member
droidmonkey
left a comment
There was a problem hiding this comment.
As discussed, this will be further fixed by a refactor on the unlock widgets.
| void SSHAgent::removeIdentityAtLock(const OpenSSHKey& key, const QUuid& uuid) | ||
| /** | ||
| * Change "remove identity on lock" setting for a key already added to the agent. | ||
| * Will to nothing if the key has not been added to the agent. |
|
|
||
| OpenSSHKey keyCopy = key; | ||
| keyCopy.clearPrivate(); | ||
| m_addedKeys[keyCopy] = removeOnLock; |
Contributor
There was a problem hiding this comment.
Previously, in 2.3.4, only those keys with the option "remove at lock" were removed from the ssh agent upon closing keepassxc.
see #2980
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes bugs introduced by the refactoring of our database classes (#2491).
Resolves #2502 by making sure that password fields are cleared when they are hidden.
Resolves issues no. 1 and 3 of #2499 by fixing conditions and reworking connected signals and tracking of added keys in our SSH agent feature.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]