Skip to content

Update Github templates#2479

Merged
droidmonkey merged 2 commits intodevelopfrom
fix/github-templates
Nov 24, 2018
Merged

Update Github templates#2479
droidmonkey merged 2 commits intodevelopfrom
fix/github-templates

Conversation

@droidmonkey
Copy link
Copy Markdown
Member

Description

Removes HTML comments in favor of markdown "comments" of the form:
[NOTE]: # ( ..... )

This will help with non-web views that actually render HTML comments as plain text (Fasthub, GitKraken Glo, etc.)

Streamlined the PR template a little and updated the wording of the contributing document.

Motivation and context

Avoiding doing school work 😁

Types of changes

  • ✅ Documentation

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • ✅ My change requires a change to the documentation and I have updated it accordingly.

@droidmonkey droidmonkey merged commit a67cac1 into develop Nov 24, 2018
@phoerious phoerious deleted the fix/github-templates branch November 24, 2018 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants