Skip to content

Adding tests for modified signal on merge.#2457

Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom
louib:merging_required
Nov 10, 2018
Merged

Adding tests for modified signal on merge.#2457
droidmonkey merged 1 commit intokeepassxreboot:developfrom
louib:merging_required

Conversation

@louib
Copy link
Copy Markdown
Member

@louib louib commented Nov 4, 2018

Adding tests on the modified signal of the database when merging. This is to make sure that the modified signal is not emitted when nothing was performed during the merge operation.

Motivation and context

The previous implementation of the merge function was always emitting the modified signal.

Types of changes

  • ✅ other (new tests)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have added tests to cover my changes.

@droidmonkey droidmonkey merged commit b1d4818 into keepassxreboot:develop Nov 10, 2018
@louib louib deleted the merging_required branch November 10, 2018 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants