Add 'Remember my choice' checkbox, resolves #51#237
Merged
Conversation
Allow user to store preference when asked whether to execute command, resolves #51
droidmonkey
approved these changes
Jan 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow user to store preference when asked whether to execute command, resolves #51.
Description
This patch adds the missing checkbox to store the user's decision whether to execute a command or not.
The preference is stored in the form of an extended attribute. When the URL of an entry changes, the attribute gets removed, so the user will be asked again next time.
How Has This Been Tested?
I performed many manual runs in different configuration contexts: creating a new entry, editing an entry, storing yes editing the entry, storing no, editing again and so on.
Screenshots (if appropriate):
Types of changes
Checklist:
Additional notes
Considering that we have at least two areas now where we use extended attributes to save internal configurations (KeePassHTTP and this), it might be reasonable to define a protected namespace prefix in the future to prevent collisions with user-defined attributes. Users won't be able to create attributes starting with that prefix.