Skip to content

Implement comparison operators#1883

Closed
mbilloo wants to merge 5 commits intokeepassxreboot:developfrom
mbilloo:develop
Closed

Implement comparison operators#1883
mbilloo wants to merge 5 commits intokeepassxreboot:developfrom
mbilloo:develop

Conversation

@mbilloo
Copy link
Copy Markdown

@mbilloo mbilloo commented Apr 28, 2018

Description

Implement comparison operators as requested by @droidmonkey

Motivation and context

PR requested by others

How has this been tested?

Tested in a previous PR locally and tests (tests have been removed since PR doesn't actually do anything )

Screenshots (if appropriate):

Types of changes

  • ✅ New feature (non-breaking change which adds functionality)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@louib louib requested a review from droidmonkey April 29, 2018 23:39
@droidmonkey
Copy link
Copy Markdown
Member

droidmonkey commented Apr 30, 2018

The build is failing, see team city

@mbilloo
Copy link
Copy Markdown
Author

mbilloo commented May 2, 2018

@droidmonkey, it looks like an issue with the configuration of TeamCity itself. It seems that apt-get failed to retrieve certain libraries because it couldn't connect to the configured IP address. See attached build log. How can I rectify this issue?
KeepassXC_Release_GCC_AppImage_1149.log

@droidmonkey
Copy link
Copy Markdown
Member

Ahhh looks like we need to increment the docker version again to kick off a full rebuild

@droidmonkey
Copy link
Copy Markdown
Member

Closed in favor of #1992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants