KdbxReader::readDatabase: abort if reading magic numbers fails#1641
Merged
phoerious merged 1 commit intokeepassxreboot:developfrom Mar 5, 2018
Merged
KdbxReader::readDatabase: abort if reading magic numbers fails#1641phoerious merged 1 commit intokeepassxreboot:developfrom
phoerious merged 1 commit intokeepassxreboot:developfrom
Conversation
Building with -flto caught the fact that we were ignoring the return value of readMagicNumbers(), which potentially left the value of 'sig2' uninitialized. Signed-off-by: Steven Noonan <steven@uplinklabs.net>
Member
|
The only way that can ever happen is if the file stream ends after less than 8 byte. But in order to satisfy pedantic people, we may as well check it. |
phoerious
approved these changes
Mar 5, 2018
Contributor
Author
|
@phoerious Yep, I agree it's unlikely. But it -is- theoretically possible and it makes the compiler happy. We could also just initialize sig1/sig2 to arbitrary values to satisfy the compiler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building with -flto caught the fact that we were ignoring the return
value of readMagicNumbers(), which potentially left the value of 'sig2'
uninitialized.