Convert from unicode to image based paperclip#1516
Merged
phoerious merged 3 commits intorelease/2.3.0from Feb 25, 2018
Merged
Conversation
affdecd to
1f130f6
Compare
weslly
approved these changes
Feb 23, 2018
phoerious
approved these changes
Feb 23, 2018
Member
|
Looks OK to me, but TC is having complaints. |
Member
Author
|
I had to move the icon loading into code that contains a GUI. When we run our non-gui tests we explicitly don't load a QApplication which is what QIcon relies on to do loading of images. Strange that there is no assert, it just crashes. |
Member
|
The tests are still crashing. |
ad4e312 to
9ebe1f4
Compare
Member
Author
|
Tests passing, but the docker image is jacked up on teamcity. |
Member
|
You need to force a rebuild. It's still trying to fetch the old libsodium18 package instead of libsodium23. |
9ebe1f4 to
51c38a1
Compare
phoerious
approved these changes
Feb 25, 2018
51c38a1 to
fd79184
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use an image instead of unicode string to display the attachment paperclip. This provides consistency in display and overcomes font deficiencies.
I made the paperclip column fixed width and corrected some sizing issues in the EntryView table.
Motivation and context
Reports received from beta testers.
Screenshots (if appropriate):
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]