Fix setting browser related values to customData#13026
Merged
phoerious merged 1 commit intokeepassxreboot:developfrom Mar 8, 2026
Merged
Fix setting browser related values to customData#13026phoerious merged 1 commit intokeepassxreboot:developfrom
phoerious merged 1 commit intokeepassxreboot:developfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug with entries saving browser integration related data even when nothing has been changed. The culprit was the
m_browserSettingsChangedthat is not reset after the first save. The value must be set to false every time entry data is loaded.Also, we shouldn't write any custom data for browser integration if the option doesn't exist in custom data, and values are not changed (remain false). This allows user to delete plugin data manually even if some other options exists.
Removed
updateLastModified()fromCustomData::copyDataFrom()function. It is not actually needed there. That function is called often and it should not update the modified time. I assume it's put there originally because when cloning entries or groups, that timestamp was updated too. Not sure if that's necessary at all with custom data.Testing strategy
The shortest way to reproduce and test this:
Type of change