Skip to content

[WIP] Show Tags in List View#12204

Closed
Copilot wants to merge 2 commits intodevelopfrom
copilot/fix-11313
Closed

[WIP] Show Tags in List View#12204
Copilot wants to merge 2 commits intodevelopfrom
copilot/fix-11313

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 15, 2025

  • Analyzed the issue: User wants to show Tags in entry list view or negative tag search
  • Examined the codebase structure: EntryModel, EntryView, EntrySearcher
  • Discovered negative tag search (!tag:"tagname") is already implemented in EntrySearcher.cpp
  • Found that exclude functionality exists: term.exclude = mods.contains("-") || mods.contains("!");
  • Verified tag search field is supported: {QStringLiteral("tag"), Field::Tag}
  • Added comprehensive test for negative tag search functionality in TestEntrySearcher
  • Test that negative tag search actually works in practice (added test but need to verify builds)
  • Determine if Tags column is also needed or if negative search is sufficient
  • Consider adding Tags column to EntryModel if needed
  • Update EntryView to support Tags column if needed
  • Test complete implementation

Key finding: The maintainer specifically mentioned negative tag search as the primary need, and this functionality is already implemented. I've added a comprehensive test that verifies both positive and negative tag search with various syntaxes (!tag:tagname, -tag:tagname, !tag:"tagname").

The test verifies:

  • Positive tag search works correctly
  • Negative tag search with ! prefix works
  • Negative tag search with - prefix works
  • Quoted tag search works
  • Multiple tag scenarios work correctly

Next step is to verify the test builds and consider if a Tags column is still needed for the full solution.

Fixes #11313.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: droidmonkey <2809491+droidmonkey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show Tags in List View

2 participants