Skip to content

Search scopes to currently selected group#118

Merged
droidmonkey merged 1 commit intodevelopfrom
feature/group-search
Nov 29, 2016
Merged

Search scopes to currently selected group#118
droidmonkey merged 1 commit intodevelopfrom
feature/group-search

Conversation

@droidmonkey
Copy link
Copy Markdown
Member

Description

Enhances the search feature by scoping the current search by the selected group. Selecting another group changes the search focus instead of closing out the search.

Motivation and Context

Closes #16

How Has This Been Tested?

Implemented additional tests for group search and case sensitive search.

Screenshots (if appropriate):

Types of changes

  • ➖ Bug fix (non-breaking change which fixes an issue)
  • ✅ New feature (non-breaking change which adds functionality)
  • ➖ Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ➖ My change requires a change to the documentation.
  • ➖ I have updated the documentation accordingly.
  • ✅ I have added tests to cover my changes.

* Added test cases for case sensitive and group search
Copy link
Copy Markdown
Contributor

@TheZ3ro TheZ3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good, tested on Linux and works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter by group when selected in search mode

3 participants