Enhance image attachment handling by caching loaded images and improv…#11699
Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom Feb 23, 2025
Merged
Conversation
Contributor
Author
|
Extract a helpful feature from this PR because PR will be implemented later |
…ing scaling logic
abf7ef1 to
56b39fd
Compare
droidmonkey
approved these changes
Feb 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance image attachment handling by caching loaded images and improving scaling logic.
Every image is cached to avoid the recreation of an image, improving performance and efficiency.
Screenshots
Before the optimization(4Mb)
After
Testing strategy
Manual Testing: Verified the changes by manually testing various image attachment scenarios.
Type of change