Show Auto-Type select dialog even if window title is empty#11603
Merged
droidmonkey merged 2 commits intodevelopfrom Feb 22, 2025
Merged
Show Auto-Type select dialog even if window title is empty#11603droidmonkey merged 2 commits intodevelopfrom
droidmonkey merged 2 commits intodevelopfrom
Conversation
There were a couple code paths that did not reset the state appropriately and could cause undefined behavior in the auto-type processing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11603 +/- ##
===========================================
+ Coverage 63.84% 63.88% +0.04%
===========================================
Files 362 362
Lines 38169 38163 -6
===========================================
+ Hits 24368 24379 +11
+ Misses 13801 13784 -17 ☔ View full report in Codecov by Sentry. |
phoerious
approved these changes
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Reconfigure how auto-type behaves when the window title is blank #11597
Always reset Auto-Type state on finished signal
There were a couple code paths that did not reset the state appropriately and could cause undefined behavior in the auto-type processing.
I split the changes into two commits.
Testing strategy
Tested on Windows with simulated window title being blank. The select dialog properly displays with the "Search all databases" checkbox checked as expected.
Type of change