Fix renaming extension key name in Database Settings#11354
Merged
droidmonkey merged 2 commits intokeepassxreboot:developfrom Dec 26, 2024
Merged
Fix renaming extension key name in Database Settings#11354droidmonkey merged 2 commits intokeepassxreboot:developfrom
droidmonkey merged 2 commits intokeepassxreboot:developfrom
Conversation
droidmonkey
requested changes
Oct 12, 2024
Member
Author
|
Fixed. |
droidmonkey
approved these changes
Oct 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When renaming a stored connection key for Browser Integration in Database Settings the key for Created timestamp is not renamed. This causes an empty value to be shown for the renamed key. Also removes the Created key when deleting stored key.
Introduces a static method
CustomData::getKeyWithPrefix()instead of different concatenations in various classes.Fixes #11353
Testing strategy
Manually.
Type of change