Skip to content

Remove view menu and disable save button#1116

Merged
TheZ3ro merged 2 commits intodevelopfrom
fix/view_menu
Oct 24, 2017
Merged

Remove view menu and disable save button#1116
TheZ3ro merged 2 commits intodevelopfrom
fix/view_menu

Conversation

@TheZ3ro
Copy link
Copy Markdown
Contributor

@TheZ3ro TheZ3ro commented Oct 24, 2017

Fix #207

Description

  • Remove view menu since it's useless
  • Disable save button if there isn't anything to save

Motivation and context

How has this been tested?

Manually, make test and with Travis

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@TheZ3ro TheZ3ro requested a review from a team October 24, 2017 17:35
@phoerious phoerious added this to the v2.3.0 milestone Oct 24, 2017
@TheZ3ro TheZ3ro merged commit 8f0e717 into develop Oct 24, 2017
@TheZ3ro TheZ3ro deleted the fix/view_menu branch October 24, 2017 18:56
@jsoref
Copy link
Copy Markdown
Contributor

jsoref commented Oct 24, 2017

For clarity: the save button shouldn't be enabled when one opens a file, it should only be enabled after one dirties a file, and thus @TheZ3ro is changing its initial state to disabled w/ this PR. (I initially read the description as indicating removal of the feature entirely, which is not what this is doing.)

@TheZ3ro
Copy link
Copy Markdown
Contributor Author

TheZ3ro commented Oct 24, 2017

Yes, the title isn't very clear

@TheZ3ro TheZ3ro mentioned this pull request Oct 31, 2017
Closed
@weslly weslly mentioned this pull request Nov 27, 2017
Merged
@a1ro a1ro mentioned this pull request Mar 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phoerious phoerious phoerious approved these changes

+1 more reviewer

@weslly weslly weslly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

user interface

Projects

None yet

Milestone

v2.3.0

Development

Successfully merging this pull request may close these issues.

Remove view>show tab bar

4 participants

@TheZ3ro @jsoref @weslly @phoerious