Skip to content

Reduce external dependencies and install YubiKey deps from EPEL#1108

Merged
phoerious merged 1 commit intodevelopfrom
feature/clean-up-dockerfile
Oct 22, 2017
Merged

Reduce external dependencies and install YubiKey deps from EPEL#1108
phoerious merged 1 commit intodevelopfrom
feature/clean-up-dockerfile

Conversation

@phoerious
Copy link
Copy Markdown
Member

Description

Shorten Dockerfile and reduce number of Copr repositories.

Motivation and context

Our new CentOS 7 Dockerfile can be reduced even further by pulling cmake3, libyubikey and libykpers-1 from CentOS/Fedora EPEL. This reduces the number of required external repositories even further and we also don't need to build the YubiKey libs ourselves anymore.

How has this been tested?

AppImage build still working, YubiKey also detected successfully at runtime.

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@phoerious phoerious added this to the v2.3.0 milestone Oct 22, 2017
@phoerious phoerious requested a review from a team October 22, 2017 19:15
@phoerious phoerious force-pushed the feature/clean-up-dockerfile branch from 9c97eef to 010690a Compare October 22, 2017 19:17
@phoerious phoerious merged commit 4c2bc56 into develop Oct 22, 2017
@phoerious phoerious deleted the feature/clean-up-dockerfile branch October 22, 2017 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants