Alternative impl for copy-to-clipboard shortcut#10966
Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom Aug 11, 2024
Merged
Alternative impl for copy-to-clipboard shortcut#10966droidmonkey merged 1 commit intokeepassxreboot:developfrom
droidmonkey merged 1 commit intokeepassxreboot:developfrom
Conversation
Member
|
I'll give this a test on macOS |
|
@droidmonkey Were you able to give it a go? 🤞 I've been bitten by this many times since upgrading to the latest version on macOS. 😅 |
Member
|
Sorry I lost track on this one, just tested on macOS and it works flawlessly now. |
077386d to
311536d
Compare
droidmonkey
approved these changes
Jul 7, 2024
It turns out that the previous implementation, based on installing an event filter in every QAction instance, does not work on macOS, likely due to a Qt bug. Attempt to work around this by using a different implementation of the same idea, by reacting to ShortcutOverride events in the MainWindow object. Fixes keepassxreboot#10929.
311536d to
2c06afd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that the previous implementation, based on installing an event filter in every
QActioninstance, does not work on macOS, likely due to a Qt bug: #10929.Attempt to work around this by using a different implementation of the same idea, by reacting to
ShortcutOverrideevents in theMainWindowobject.Fixes #10929 – hopefully.
Testing strategy
Tested manually on Linux/Wayland. Also ran all tests, including GUI tests.
Type of change