Skip to content

AutoType: resolve placeholders for title in window associations#1038

Merged
TheZ3ro merged 3 commits intokeepassxreboot:developfrom
frostasm:resolve-placeholders-in-window-association-title
Oct 23, 2017
Merged

AutoType: resolve placeholders for title in window associations#1038
TheZ3ro merged 3 commits intokeepassxreboot:developfrom
frostasm:resolve-placeholders-in-window-association-title

Conversation

@frostasm
Copy link
Copy Markdown
Contributor

@frostasm frostasm commented Oct 5, 2017

Description

Allow to use entry placeholders in window association title

Motivation and context

This feature useful when we need to match window by some specific data (which not convenient to use as the name or the url), for example ip-address or mac-address, etc.

How has this been tested?

Manually, with using windows that do not contain name or url but contain value from the entry attribute.

Screenshot:

image

Types of changes

  • ✅ New feature (non-breaking change which adds functionality)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • My change may require a change to the documentation.

@droidmonkey
Copy link
Copy Markdown
Member

droidmonkey commented Oct 5, 2017

It might be smart to pass this through the new "maskPasswordPlaceholders" function first to prevent accidental spillage. You wouldn't use {PASSWORD} in this context, but just incase you did it would prevent issues.

@frostasm
Copy link
Copy Markdown
Contributor Author

frostasm commented Oct 6, 2017

"maskPasswordPlaceholders" function helps to hide confidential information, but the association window title is never shown to the user after the call "resolveMultiplePlaceholders" function. Therefore, I think that we do not need to use the specified function.

@frostasm
Copy link
Copy Markdown
Contributor Author

frostasm commented Oct 6, 2017

But on the other hand, if in the list we display the actual data taken from attributes, we should use "maskPasswordPlaceholders" function.
image

@droidmonkey
Copy link
Copy Markdown
Member

droidmonkey commented Oct 7, 2017

Are you intending to implement the display of the resolved placeholders (I think its a good idea)

@frostasm
Copy link
Copy Markdown
Contributor Author

frostasm commented Oct 7, 2017

Are you intending to implement the display of the resolved placeholders (I think its a good idea)

@droidmonkey done ;)

Copy link
Copy Markdown
Member

@droidmonkey droidmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@frostasm
Copy link
Copy Markdown
Contributor Author

guys, do you need any changes to merge this branch into develop?

@TheZ3ro
Copy link
Copy Markdown
Contributor

TheZ3ro commented Oct 23, 2017

can you rebase it on develop?

@frostasm frostasm force-pushed the resolve-placeholders-in-window-association-title branch from 67134e4 to b6387f7 Compare October 23, 2017 19:55
@frostasm
Copy link
Copy Markdown
Contributor Author

@TheZ3ro done

@TheZ3ro TheZ3ro merged commit e95f36c into keepassxreboot:develop Oct 23, 2017
@frostasm frostasm deleted the resolve-placeholders-in-window-association-title branch October 24, 2017 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants