Fix parsing stat file for polkit#10350
Merged
droidmonkey merged 1 commit intodevelopfrom Mar 29, 2024
Merged
Conversation
HexF
approved these changes
Mar 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10350 +/- ##
===========================================
- Coverage 63.75% 63.74% -0.01%
===========================================
Files 362 362
Lines 43997 44004 +7
===========================================
Hits 28048 28048
- Misses 15949 15956 +7 ☔ View full report in Codecov by Sentry. |
2e3f96e to
2421b70
Compare
|
Any update when this will be merged? |
|
@droidmonkey is the fix included in the latest build? If so - I cannot confirm it to be working now. I am getting the same error in the UI as before, with the difference that no logs are being produced |
Member
Author
|
It should be, yes |
Member
Author
|
@rgarcia89 you might be running into this issue: #10523 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing strategy
Tested with various errors in the file and with an actual stat file
Type of change