Closed
Conversation
phoerious
requested changes
Oct 3, 2017
| #include "ScreenLockListenerMac.h" | ||
| #endif | ||
| #if defined(Q_OS_LINUX) | ||
| #if defined(Q_OS_UNIX) |
Member
There was a problem hiding this comment.
You need to exclude Q_OS_DARWIN here at least and I'm not sure about other BSDs. If in doubt, enable only Linux and OpenBSD (which you already did in CMakeLists.txt).
Merged
Member
|
Replacement PR: #1328 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make keepassxc BSD/UNIX ready
Description
s/Q_OS_LINUX/Q_OS_UNIX/gMotivation and context
I'm the maintainer of the OpenBSD keepassxc: port http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/security/keepassxc/ and I would like to push my patches upstream.
How has this been tested?
Build and runs fine over months on OpenBSD amd64 (6.1 and 6.2).
Checklist:
-DWITH_ASAN=ON.