Skip to content

New entry screen causes loss passwords during entry creation #870

@t4777sd

Description

@t4777sd

Currently when you create a new entry you get a blank password box. You click on the icon for the password generator. It has a password box that says "password" that is filled in. You would think that the filled in password would become the password for the entry. However, that is not the case. If you click "Apply", you will then be creating an entry with an empty password when the entry should have the password that was filled in the "password" box in the password generator.

Expected Behavior

In KeePass, I am 99% sure it does not function this way. When you are in the password generator with an empty password, the password the generator comes up with will be the password that gets assigned to entry. It will not be an empty password (forcing you to copy the password from one "password" field to another "password" field). Hitting apply, when the password box is empty, should assign the password that is in the "password" field in the generator. The fact that it is named "password" and filled-in on the entry-form indicates that it will become the password.

Possible Solution

  1. Best update header file for Qt5 #1: Hitting apply with an empty password field and an open generator form with a filled in "password" field will assign the password in the generator to the entry

  2. Best "KeePassHttp is not running" error in Pass|Fox #2: Password generator should be its own popup window. Hitting Apply for password generator will fill in the password for the entry (This is how keepass works). This avoids the confusion caused by having a form within a form which makes all context ambiguous.

  3. Minimum: At a minimum, if "apply" is hit with an empty password field there should be a warning confirmation box that says "No password has been entered for this entry. Are you sure you want to save it?"

Context

This already cost me pretty big when I created an entry, copying the password in the generator, clicking apply assuming the entry would have the password the generator just generated especially because the form now had a filled in "password" (with the generator open there are now two "password" form fields. Having a form within a form makes context / behavior ambiguous) and I then lost access to my bitcoin wallet with no way to recover it. So, this issue is pretty serious that can cost people lots of money.

Debug Info

KeePassXC - Version 2.2.0
Revision: 9a7e685

Operating system: Linux

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions