-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
When password generator is set to "Passphrase", quality meter isn't as dynamic #867
Description
Expected Behavior
When I manually edit a generated Passphrase, the Password Quality meter should change to reflect the edit. Currently, when the password generator is set to "Password", the meter does change with edits, as expected.
Current Behavior
Currently, the Password Quality meter does not dynamically change when you manually edit a generated passphrase. It only changes when a new passphrase is generated.
Steps to Reproduce (for bugs)
- Create or edit an entry
- Click the black die to generate a new password
- Click passphrase to generate a passphrase.
- Drag the slider to generate a random 7-word passphrase. Let's say it has 90.47 bits of entropy (Password Quality says "Good" in this case).
- Click into the password text box and delete some of the 7 words. Entropy is still displayed as 90.47 bits and the Password Quality still says it's "Good".
Context
This isn't a huge thing, as users may not be frequently manually editing generated passphrases, but I could see it might lead to someone thinking a three-word passphrase was "Good". This could also affect users who want to add a few numbers and/or symbols to the end of a generated passphrase, either to meet a website's password requirements or just out of paranoia, etc.
Debug Info
KeePassXC - Version 2.2.0
Revision: caa49a8
Libraries:
- Qt 5.9.0
- libgcrypt 1.7.7
Operating system: OS X Yosemite (10.10)
CPU architecture: x86_64
Kernel: darwin 14.5.0
Enabled extensions:
- KeePassHTTP
- Auto-Type
- YubiKey
I also reproduced this issue with KeePassXC 2.2.0 on Ubuntu 16.04 / Qt 5.7.1 / libgcrypt 1.7.6-beta
