Skip to content

Fetching favicon for Non-ASCII and Internationalized domains fails #731

@lopopolo

Description

@lopopolo

Expected Behavior

  • Google fallback should use https.
  • Non-ASCII domains need to be %-encoded when constructing the google fallback url because they are url query string parameters. For example, http://💩.la. QUrlQuery::addQueryItem(?
  • Internationalized domain names are converted to Punycode by browsers before making requests to the domain. I believe QUrl does this but am not sure. Tests needed?

Current Behavior

  • Google fallback is an http endpoint
  • Non-ASCII domains fail to fetch favicons from google fallback

Possible Solution

Steps to Reproduce (for bugs)

  1. Create a new entry with http://💩.la as the URL
  2. Click on the "Icon" icon
  3. Click download favicon
  4. Observe error popup

Context

Debug Info

KeePassXC - Version 2.2.0
Revision: caa49a8

Libraries:

  • Qt 5.9.0
  • libgcrypt 1.7.7

Operating system: macOS Sierra (10.12)
CPU architecture: x86_64
Kernel: darwin 16.6.0

Enabled extensions:

  • KeePassHTTP
  • Auto-Type
  • YubiKey

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions