Expected Behavior
- Google fallback should use https.
- Non-ASCII domains need to be %-encoded when constructing the google fallback url because they are url query string parameters. For example, http://💩.la. QUrlQuery::addQueryItem(?
- Internationalized domain names are converted to Punycode by browsers before making requests to the domain. I believe QUrl does this but am not sure. Tests needed?
Current Behavior
- Google fallback is an http endpoint
- Non-ASCII domains fail to fetch favicons from google fallback
Possible Solution
Steps to Reproduce (for bugs)
- Create a new entry with http://💩.la as the URL
- Click on the "Icon" icon
- Click download favicon
- Observe error popup
Context
Debug Info
KeePassXC - Version 2.2.0
Revision: caa49a8
Libraries:
Operating system: macOS Sierra (10.12)
CPU architecture: x86_64
Kernel: darwin 16.6.0
Enabled extensions:
- KeePassHTTP
- Auto-Type
- YubiKey
Expected Behavior
Current Behavior
Possible Solution
Steps to Reproduce (for bugs)
Context
Debug Info
KeePassXC - Version 2.2.0
Revision: caa49a8
Libraries:
Operating system: macOS Sierra (10.12)
CPU architecture: x86_64
Kernel: darwin 16.6.0
Enabled extensions: