Skip to content

Option pointer but may be nullptr in BaseStyle.cpp #4766

Closed
#4752
Closed
Option pointer but may be nullptr in BaseStyle.cpp#4766
#4752
Assignees
phoerious
Labels
PRE-RELEASE BUG
@qarmin

Description

@qarmin
qarmin
opened on May 20, 2020

In line 4624 option pointer is used but in 4628 is checked if is null

keepassxc/src/gui/styles/base/BaseStyle.cpp

Lines 4624 to 4628 in 26ea274

auto ph_swatchPtr = Ph::getCachedSwatchOfQPalette(&d->swatchCache, &d->headSwatchFastKey, option->palette);
const Ph::PhSwatch& swatch = *ph_swatchPtr.data();
// Qt code in table views for drawing grid lines is broken. See case for
// CE_ItemViewItem painting for more information.
return option ? static_cast<int>(swatch.color(S_base_divider).rgb()) : 0;

Metadata

Metadata

Assignees

Labels

PRE-RELEASE BUG

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions