You should be able to apply this fix without any visual changes occurring in your UI.

I think these are the palette values you're using:

keepassxc/src/gui/styles/light/LightStyle.cpp

Lines 33 to 39 in 5c69875

    
           palette.setColor(QPalette::Active, QPalette::WindowText, QStringLiteral("#1D1D20")); 
        
           palette.setColor(QPalette::Inactive, QPalette::WindowText, QStringLiteral("#252528")); 
        
           palette.setColor(QPalette::Disabled, QPalette::WindowText, QStringLiteral("#8C8C92")); 
        
           palette.setColor(QPalette::Active, QPalette::Text, QStringLiteral("#1D1D20")); 
        
           palette.setColor(QPalette::Inactive, QPalette::Text, QStringLiteral("#252528")); 
        
           palette.setColor(QPalette::Disabled, QPalette::Text, QStringLiteral("#8C8C92"));

keepassxc/src/gui/styles/dark/DarkStyle.cpp

Lines 32 to 38 in 5c69875

    
           palette.setColor(QPalette::Active, QPalette::WindowText, QStringLiteral("#CACBCE")); 
        
           palette.setColor(QPalette::Inactive, QPalette::WindowText, QStringLiteral("#C8C8C6")); 
        
           palette.setColor(QPalette::Disabled, QPalette::WindowText, QStringLiteral("#707070")); 
        
           palette.setColor(QPalette::Active, QPalette::Text, QStringLiteral("#CACBCE")); 
        
           palette.setColor(QPalette::Inactive, QPalette::Text, QStringLiteral("#C8C8C6")); 
        
           palette.setColor(QPalette::Disabled, QPalette::Text, QStringLiteral("#707070"));

For these palettes, and my own test palettes, and all of the palettes I've seen in the wild, QPalette::Text and QPalette::WindowText ColorRoles use the same color value.

Thanks for finding this bug.

Unrelated aside: I saw that you're using QStringLiteral to populate the color values. QStringLiteral tends to generate a fair bit of binary bloat, at least with the compilers I've used. You might instead want to consider using integer literals, if that sort of thing is a priority in your project.

	palette.setColor(QPalette::Active, QPalette::WindowText, QStringLiteral("#1D1D20"));
	palette.setColor(QPalette::Inactive, QPalette::WindowText, QStringLiteral("#252528"));
	palette.setColor(QPalette::Disabled, QPalette::WindowText, QStringLiteral("#8C8C92"));

	palette.setColor(QPalette::Active, QPalette::Text, QStringLiteral("#1D1D20"));
	palette.setColor(QPalette::Inactive, QPalette::Text, QStringLiteral("#252528"));
	palette.setColor(QPalette::Disabled, QPalette::Text, QStringLiteral("#8C8C92"));

	colors[S_text] = pal.color(QPalette::Text);
	colors[S_text] = pal.color(QPalette::WindowText);
	colors[S_windowText] = pal.color(QPalette::WindowText);

Uh oh!

Copy paste bug in BaseStyle.cpp #4765

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions